Repository navigation
Add example of limiting particle timestep by local cfl in schism tuto… - #3016
fluidnumericsJoe wants to merge 5 commits into
Conversation
for more information, see https://pre-commit.ci
erikvansebille
left a comment
There was a problem hiding this comment.
Thanks for adding this extra context, @fluidnumericsJoe! Below a few small comments (I can't put comments directly on the notebook in GitHub)
- Is "altitude" the right word in the comment of cell [5]? That to me suggests (3D) height?
- Avoid variable names like
h,eandpin that same cell - make them more explicit so users understand what's going on? - CFL number hasn't been introduced in cell [5]. Could you move that whole cell down to the section of cell [9]? That will also make it easier to refer to this part of the tutorial directly, because all information is in one subsection
- Make explicit that the math symbol
$C$ is the same asCFL_target - Should we add a link to the CFL-section on the
tutorial_dt_integratorstoo?
|
erikvansebille
left a comment
There was a problem hiding this comment.
Thanks for making these updates, however I don't see the link back from the dt_integration notebook to this notebook?
Description
This PR adds an example of limiting particle timestep by local cfl in schism tutorial
Checklist
mainfor normal development,v3-supportfor v3 support)